change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) #11236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjac0bs
commented
Nov 8, 2024
Comment on lines
+53
to
+68
| - 👀 Doing a self review | ||
| - ❔ Our [contribution guidelines](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md) | ||
| - 🤏 Splitting feature into small PRs | ||
| - ➕ Adding a [changeset](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md#writing-a-changeset) | ||
| - 🧪 Providing/improving test coverage | ||
| - 🔐 Removing all sensitive information from the code and PR description | ||
| - 🚩 Using a feature flag to protect the release | ||
| - 👣 Providing comprehensive reproduction steps | ||
| - 📑 Providing or updating our documentation | ||
| - 🕛 Scheduling a pair reviewing session | ||
| - 📱 Providing mobile support | ||
| - ♿ Providing accessibility support | ||
|
|
||
| - [ ] 👀 Doing a self review | ||
| - [ ] ❔ Our [contribution guidelines](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md) | ||
| - [ ] 🤏 Splitting feature into small PRs | ||
| - [ ] ➕ Adding a [changeset](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md#writing-a-changeset) | ||
| - [ ] 🧪 Providing/Improving test coverage | ||
| - [ ] 🔐 Removing all sensitive information from the code and PR description | ||
| - [ ] 🚩 Using a feature flag to protect the release | ||
| - [ ] 👣 Providing comprehensive reproduction steps | ||
| - [ ] 📑 Providing or updating our documentation | ||
| - [ ] 🕛 Scheduling a pair reviewing session | ||
| - [ ] 📱 Providing mobile support | ||
| - [ ] ♿ Providing accessibility support | ||
| <br/> | ||
|
|
||
| - [ ] I have read and considered all applicable items listed above. |
There was a problem hiding this comment.
Converted to bullet points instead of checkboxes and added a final checkbox for contributors to acknowledge the section. Do we feel okay about this?
There was a problem hiding this comment.
These are all good changes! I think we need a followup after opening a PR.
Some suggestions after opening a PR (could be weighed by a larger group)
- Let's remove the bullets cause it impacts reading negatively IMO. Can do it as such with markdown I believe
First item (<-- two spaces)
Second item - Let's make the title an incentive: "What will help merge this faster (if applies)"
- Let's include this section in the "deletable" description of this PR (what's under
> **Note**: Remove this section before opening the pull request
There was a problem hiding this comment.
@abailly-akamai Thanks for the feedback! I just added this as a cafe item for Thursday.
Comment on lines
+70
to
+77
| ## As an Author, before moving this PR from Draft to Open, I confirmed ✅ | ||
|
|
||
| - [ ] All unit tests are passing | ||
| - [ ] TypeScript compilation succeeded without errors | ||
| - [ ] Code passes all linting rules | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
This was a suggestion from Retro. Open to feedback on how we want to represent these as requirements.
mjac0bs
requested review from
carrillo-erik and
cpathipa
and removed request for
a team
mjac0bs
added
Ready for Review
Documentation
Cloud Manager UI test results🎉 445 passing tests on test run #3 ↗︎
|
jdamore-linode
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
This is great, thanks @mjac0bs! I really like consolidating all the "As an Author I have considered..." bullets into a single checkbox.
Comment on lines
+40
to
+42
|
|
||
| - [ ] ... | ||
| - [ ] ... |
There was a problem hiding this comment.
What's the reasoning behind using checkboxes for reproduction/verification steps?
There was a problem hiding this comment.
Requiring slightly more engagement on the Author's part to confirm they did, in fact, verify those things since all of them should apply to every PR opened. (This differs from the consideration bullets above, where some did not always apply, which was cause for potential confusion.) Any concerns about the checks, or were you thinking it would be best to aim for consistency?
Related tangent:
I'm not sure I like the checklist -> bulleted change above either. I think it will encourage more automatic skimming. The potential confusion mentioned above could be solved by adding a line like "Please check only those that apply." before the consideration checklist.
There was a problem hiding this comment.
Gotcha! I always looked at this more as a spot to put step-by-step instructions for reviewers to follow when verifying PR changes, but I see plenty of value in emphasizing that authors should also be doing their part to self-review and test their PRs too.
Edit: Also totally hear you about the checkbox/bullet change. I like the idea of saving ourselves some clicks, but if we think it might come at the cost of having devs overlook important points that might bite us later then I could understand going back to the way it was.
There was a problem hiding this comment.
Oh shoot, I misread this comment and thought it was referring to the checks in the section below where Connie commented. That's my bad.
But the answer is somewhat similar! In retro, we talked about liking when Authors provide checklists for their reviewers - it's easier to review, so we want to encourage that! In that same vein, Authors should definitely also be confirming their own changes.
There was a problem hiding this comment.
but if we think it might come at the cost of having devs overlook important points that might bite us later then I could understand going back to the way it was.
I'm going to merge this change and we'll give the bullets a try. Will be keeping an eye out for whether the single checkbox works in our favor and raise the issue if we should revert!
coliu-akamai
approved these changes
Nov 12, 2024
mjac0bs
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 54s |
| Commit |
|
| Committer | Mariah Jacobs |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
santoshp210-akamai
added a commit
to santoshp210-akamai/manager
that referenced
this pull request
Nov 13, 2024
* feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (linode#11199) * feat: [M3-8831] - New GPUv2 egress transfer display (linode#11209) * Add new gpuV2 egress transferlogic * light cleanup * adjust e2e s * Added changeset: New GPUv2 egress transfer helpers * feedback @coliu-akamai @hkhalil-akamai * feedback @coliu-akamai @jaalah-akamai * feedback optimization * change: [M3-8806] - Disable unsupported images for distributed regions (linode#11206) ## Description 📝 In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did ## Changes 🔄 List any change relevant to the reviewer. - Disable unsupported images/distros for distributed regions in Linode Create - Removed the distributed icon & associated icon text - Removed the word `currently` in the Add-Ons warning notice for distributed regions - Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component ## Target release date 🗓️ 11/12 ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags ### Verification steps (How to verify changes) - Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab: - Select a core region -> No Images/distributions should be disabled - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled - There should be no regressions in the components that were refactored - Ensure unit tests and e2e tests are passing locally/remotely * fix: [UIE-8246] - DBaaS provisioning 2 node clusters (linode#11218) * feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (linode#11178) * feat: [M3-8528] - Include Object Storage in Support Tickets * query change * Added changeset: Include Object Storage buckets in Support tickets dropdown * added link support for object storage * removed redundant query * query updation and restructuring request payload * Added changeset * Initial Changelog * refactor: [M3-8646] – Migrate `Divider` to `ui` package (linode#11205) * refactor: [M3-8646] – Migrate `Divider` to `ui` package * Added changeset: Migrate Divider to ui package * migrating all imports * removing redundant hook imports * updated the import for omittedProps * UIE-8247: Conditionally give the new docs as the link on database landing page (linode#11227) * fix: [M3-8764] - Kubernetes UI issues (linode#11217) * initial clean up * save progress * add changeset * fix type error * feedback @mjac0bs * a few more small fixes * a few more small fixes --------- Co-authored-by: Banks Nussman <[email protected]> * upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (linode#11225) * upcoming: [DI-18419] - chart post processing for missing timestamps * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Added changeset * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - early returns for empty array --------- Co-authored-by: vmangalr <[email protected]> * Update changelog * refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (linode#11228) * migrate stack, update organization for divider/icon button * Added changeset: `Stack` component to `ui` package * refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (linode#11174) * Move Notice to UI package and update imports * Add test imports * Add renderWithTheme and other changes to make tests pass * Fix broken icon imports * Added changeset: Move `Notice` and `Tooltip` components to UI package * Feedback @dwiley-akamai: consolidate imports and rename icon exports * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (linode#11172) * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. * Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object. * Update changeset description Co-authored-by: Purvesh Makode <[email protected]> * remove optional chaining * change Text from "Subnets" to "Subnet" * remove extra borderTop * refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object * Add descriptive variable name --------- Co-authored-by: Purvesh Makode <[email protected]> * upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (linode#11226) * upcoming: [DI-21814] - DBaaS instances order by label * upcoming: [DI-21814] - Added changeset * DI-21814: use map for better readability and optimisations --------- Co-authored-by: vmangalr <[email protected]> * UIE-8254: Add tooltip for ipv6 for new db clusters (linode#11231) * feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (linode#11232) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * feat: [UIE-8193] - Tooltip context for small screens * feat: [UIE-8193] - Tooltip for Create/Resize Database table (linode#11223) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table * feat: [UIE-8193] - Tooltip context for small screens * DBaaS additions * GPU egress transfer copy update (linode#11235) * default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (linode#11234) Co-authored-by: Talmai Oliveira <[email protected]> * Update PULL_REQUEST_TEMPLATE.md (linode#11219) * change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (linode#11221) * Update 08-testing.md for userEvent * Fix typo * Address feedback; also further clean up linting issues the doc * Fix a bad test that was not following good practices * Added changeset: Update developer docs on unit testing user events * Update changelog * Fix LKE create ACL tests (linode#11237) * feat: [M3-8665] - add option to copy token in LKE details page. (linode#11179) * feat: [M3-8665] - add option to copy token in LKE details page. * Added changeset: option to copy token in LKE details page * Change the "Copy Token" button to use asynchronous functionality * remove extra styling * refactor: [M3-8665] - add option to copy token in LKE details page. * Change cypress test for LKE update spec * fix: sx styling for Textfield component (linode#11246) * spread containerProps sx * spread props.sx as well whoops * fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (linode#11247) * don't fetch when `type` is an empty string * fix and changelog entry --------- Co-authored-by: Banks Nussman <[email protected]> * change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (linode#11236) * Make updates discussed to PR template during retro * Add changeset --------- Co-authored-by: corya-akamai <[email protected]> Co-authored-by: Alban Bailly <[email protected]> Co-authored-by: Hana Xu <[email protected]> Co-authored-by: Harsh Shankar Rao <[email protected]> Co-authored-by: Jaalah Ramos <[email protected]> Co-authored-by: rodonnel-akamai <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: venkatmano-akamai <[email protected]> Co-authored-by: vmangalr <[email protected]> Co-authored-by: Connie Liu <[email protected]> Co-authored-by: Hussain Khalil <[email protected]> Co-authored-by: hasyed-akamai <[email protected]> Co-authored-by: Purvesh Makode <[email protected]> Co-authored-by: ankitaakamai <[email protected]> Co-authored-by: mpolotsk-akamai <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: John Callahan <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> Co-authored-by: jdamore-linode <[email protected]> Co-authored-by: Hana Xu <[email protected]>
santoshp210-akamai
added a commit
to santoshp210-akamai/manager
that referenced
this pull request
Nov 13, 2024
* feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (linode#11199) * feat: [M3-8831] - New GPUv2 egress transfer display (linode#11209) * Add new gpuV2 egress transferlogic * light cleanup * adjust e2e s * Added changeset: New GPUv2 egress transfer helpers * feedback @coliu-akamai @hkhalil-akamai * feedback @coliu-akamai @jaalah-akamai * feedback optimization * change: [M3-8806] - Disable unsupported images for distributed regions (linode#11206) ## Description 📝 In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did ## Changes 🔄 List any change relevant to the reviewer. - Disable unsupported images/distros for distributed regions in Linode Create - Removed the distributed icon & associated icon text - Removed the word `currently` in the Add-Ons warning notice for distributed regions - Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component ## Target release date 🗓️ 11/12 ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags ### Verification steps (How to verify changes) - Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab: - Select a core region -> No Images/distributions should be disabled - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled - There should be no regressions in the components that were refactored - Ensure unit tests and e2e tests are passing locally/remotely * fix: [UIE-8246] - DBaaS provisioning 2 node clusters (linode#11218) * feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (linode#11178) * feat: [M3-8528] - Include Object Storage in Support Tickets * query change * Added changeset: Include Object Storage buckets in Support tickets dropdown * added link support for object storage * removed redundant query * query updation and restructuring request payload * Added changeset * Initial Changelog * refactor: [M3-8646] – Migrate `Divider` to `ui` package (linode#11205) * refactor: [M3-8646] – Migrate `Divider` to `ui` package * Added changeset: Migrate Divider to ui package * migrating all imports * removing redundant hook imports * updated the import for omittedProps * UIE-8247: Conditionally give the new docs as the link on database landing page (linode#11227) * fix: [M3-8764] - Kubernetes UI issues (linode#11217) * initial clean up * save progress * add changeset * fix type error * feedback @mjac0bs * a few more small fixes * a few more small fixes --------- Co-authored-by: Banks Nussman <[email protected]> * upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (linode#11225) * upcoming: [DI-18419] - chart post processing for missing timestamps * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Added changeset * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - early returns for empty array --------- Co-authored-by: vmangalr <[email protected]> * Update changelog * refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (linode#11228) * migrate stack, update organization for divider/icon button * Added changeset: `Stack` component to `ui` package * refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (linode#11174) * Move Notice to UI package and update imports * Add test imports * Add renderWithTheme and other changes to make tests pass * Fix broken icon imports * Added changeset: Move `Notice` and `Tooltip` components to UI package * Feedback @dwiley-akamai: consolidate imports and rename icon exports * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (linode#11172) * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. * Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object. * Update changeset description Co-authored-by: Purvesh Makode <[email protected]> * remove optional chaining * change Text from "Subnets" to "Subnet" * remove extra borderTop * refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object * Add descriptive variable name --------- Co-authored-by: Purvesh Makode <[email protected]> * upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (linode#11226) * upcoming: [DI-21814] - DBaaS instances order by label * upcoming: [DI-21814] - Added changeset * DI-21814: use map for better readability and optimisations --------- Co-authored-by: vmangalr <[email protected]> * UIE-8254: Add tooltip for ipv6 for new db clusters (linode#11231) * feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (linode#11232) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * feat: [UIE-8193] - Tooltip context for small screens * feat: [UIE-8193] - Tooltip for Create/Resize Database table (linode#11223) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table * feat: [UIE-8193] - Tooltip context for small screens * DBaaS additions * GPU egress transfer copy update (linode#11235) * default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (linode#11234) Co-authored-by: Talmai Oliveira <[email protected]> * Update PULL_REQUEST_TEMPLATE.md (linode#11219) * change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (linode#11221) * Update 08-testing.md for userEvent * Fix typo * Address feedback; also further clean up linting issues the doc * Fix a bad test that was not following good practices * Added changeset: Update developer docs on unit testing user events * Update changelog * Fix LKE create ACL tests (linode#11237) * feat: [M3-8665] - add option to copy token in LKE details page. (linode#11179) * feat: [M3-8665] - add option to copy token in LKE details page. * Added changeset: option to copy token in LKE details page * Change the "Copy Token" button to use asynchronous functionality * remove extra styling * refactor: [M3-8665] - add option to copy token in LKE details page. * Change cypress test for LKE update spec * fix: sx styling for Textfield component (linode#11246) * spread containerProps sx * spread props.sx as well whoops * fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (linode#11247) * don't fetch when `type` is an empty string * fix and changelog entry --------- Co-authored-by: Banks Nussman <[email protected]> * change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (linode#11236) * Make updates discussed to PR template during retro * Add changeset * refactor: [M3-8900] - Move `RadioGroup` to `@linode/ui` package (linode#11254) * Move RadioGroup to ui package * Added changeset: Move `RadioGroup` from `manager` to `ui` package --------- Co-authored-by: corya-akamai <[email protected]> Co-authored-by: Alban Bailly <[email protected]> Co-authored-by: Hana Xu <[email protected]> Co-authored-by: Harsh Shankar Rao <[email protected]> Co-authored-by: Jaalah Ramos <[email protected]> Co-authored-by: rodonnel-akamai <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: venkatmano-akamai <[email protected]> Co-authored-by: vmangalr <[email protected]> Co-authored-by: Connie Liu <[email protected]> Co-authored-by: Hussain Khalil <[email protected]> Co-authored-by: hasyed-akamai <[email protected]> Co-authored-by: Purvesh Makode <[email protected]> Co-authored-by: ankitaakamai <[email protected]> Co-authored-by: mpolotsk-akamai <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: John Callahan <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> Co-authored-by: jdamore-linode <[email protected]> Co-authored-by: Hana Xu <[email protected]>
jaalah-akamai
pushed a commit
that referenced
this pull request
Nov 18, 2024
…ts for the Create Alert Definition Form (#11255) * Upcoming : [DI:21546] - Added the create button and name,description,severity components from General Information for the Create Alert Definition form * Upcoming: [DI:21456] - Added unit test for AlertSeverity component, changed the naming of properties in the Alert type, updated the url of endpoint * Upcoming: [DI:21546] - Added the unit test for CreateAlertDefinition component * upcoming: [DI:21546] - Added the onChange for the tabs * Upcoming: [DI-21546] - Removed unneccessary components and made changes to the Create Alert forma and Severity Select component * Upcoming: [DI-21694] - Modified the changes with Severity component, modified and added appropriate types * Upcoming: [DI-21694] - Added null as empty value for the Severity component, Fixed the Unit Tests for Severity component, fixed styling between components in Create Alert Form * Merging latest develop changes (#23) * feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (#11199) * feat: [M3-8831] - New GPUv2 egress transfer display (#11209) * Add new gpuV2 egress transferlogic * light cleanup * adjust e2e s * Added changeset: New GPUv2 egress transfer helpers * feedback @coliu-akamai @hkhalil-akamai * feedback @coliu-akamai @jaalah-akamai * feedback optimization * change: [M3-8806] - Disable unsupported images for distributed regions (#11206) ## Description 📝 In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did ## Changes 🔄 List any change relevant to the reviewer. - Disable unsupported images/distros for distributed regions in Linode Create - Removed the distributed icon & associated icon text - Removed the word `currently` in the Add-Ons warning notice for distributed regions - Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component ## Target release date 🗓️ 11/12 ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags ### Verification steps (How to verify changes) - Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab: - Select a core region -> No Images/distributions should be disabled - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled - There should be no regressions in the components that were refactored - Ensure unit tests and e2e tests are passing locally/remotely * fix: [UIE-8246] - DBaaS provisioning 2 node clusters (#11218) * feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (#11178) * feat: [M3-8528] - Include Object Storage in Support Tickets * query change * Added changeset: Include Object Storage buckets in Support tickets dropdown * added link support for object storage * removed redundant query * query updation and restructuring request payload * Added changeset * Initial Changelog * refactor: [M3-8646] – Migrate `Divider` to `ui` package (#11205) * refactor: [M3-8646] – Migrate `Divider` to `ui` package * Added changeset: Migrate Divider to ui package * migrating all imports * removing redundant hook imports * updated the import for omittedProps * UIE-8247: Conditionally give the new docs as the link on database landing page (#11227) * fix: [M3-8764] - Kubernetes UI issues (#11217) * initial clean up * save progress * add changeset * fix type error * feedback @mjac0bs * a few more small fixes * a few more small fixes --------- Co-authored-by: Banks Nussman <[email protected]> * upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (#11225) * upcoming: [DI-18419] - chart post processing for missing timestamps * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Added changeset * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - early returns for empty array --------- Co-authored-by: vmangalr <[email protected]> * Update changelog * refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (#11228) * migrate stack, update organization for divider/icon button * Added changeset: `Stack` component to `ui` package * refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (#11174) * Move Notice to UI package and update imports * Add test imports * Add renderWithTheme and other changes to make tests pass * Fix broken icon imports * Added changeset: Move `Notice` and `Tooltip` components to UI package * Feedback @dwiley-akamai: consolidate imports and rename icon exports * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (#11172) * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. * Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object. * Update changeset description Co-authored-by: Purvesh Makode <[email protected]> * remove optional chaining * change Text from "Subnets" to "Subnet" * remove extra borderTop * refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object * Add descriptive variable name --------- Co-authored-by: Purvesh Makode <[email protected]> * upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (#11226) * upcoming: [DI-21814] - DBaaS instances order by label * upcoming: [DI-21814] - Added changeset * DI-21814: use map for better readability and optimisations --------- Co-authored-by: vmangalr <[email protected]> * UIE-8254: Add tooltip for ipv6 for new db clusters (#11231) * feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (#11232) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * feat: [UIE-8193] - Tooltip context for small screens * feat: [UIE-8193] - Tooltip for Create/Resize Database table (#11223) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table * feat: [UIE-8193] - Tooltip context for small screens * DBaaS additions * GPU egress transfer copy update (#11235) * default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (#11234) Co-authored-by: Talmai Oliveira <[email protected]> * Update PULL_REQUEST_TEMPLATE.md (#11219) * change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (#11221) * Update 08-testing.md for userEvent * Fix typo * Address feedback; also further clean up linting issues the doc * Fix a bad test that was not following good practices * Added changeset: Update developer docs on unit testing user events * Update changelog * Fix LKE create ACL tests (#11237) * feat: [M3-8665] - add option to copy token in LKE details page. (#11179) * feat: [M3-8665] - add option to copy token in LKE details page. * Added changeset: option to copy token in LKE details page * Change the "Copy Token" button to use asynchronous functionality * remove extra styling * refactor: [M3-8665] - add option to copy token in LKE details page. * Change cypress test for LKE update spec * fix: sx styling for Textfield component (#11246) * spread containerProps sx * spread props.sx as well whoops * fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (#11247) * don't fetch when `type` is an empty string * fix and changelog entry --------- Co-authored-by: Banks Nussman <[email protected]> * change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (#11236) * Make updates discussed to PR template during retro * Add changeset --------- Co-authored-by: corya-akamai <[email protected]> Co-authored-by: Alban Bailly <[email protected]> Co-authored-by: Hana Xu <[email protected]> Co-authored-by: Harsh Shankar Rao <[email protected]> Co-authored-by: Jaalah Ramos <[email protected]> Co-authored-by: rodonnel-akamai <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: venkatmano-akamai <[email protected]> Co-authored-by: vmangalr <[email protected]> Co-authored-by: Connie Liu <[email protected]> Co-authored-by: Hussain Khalil <[email protected]> Co-authored-by: hasyed-akamai <[email protected]> Co-authored-by: Purvesh Makode <[email protected]> Co-authored-by: ankitaakamai <[email protected]> Co-authored-by: mpolotsk-akamai <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: John Callahan <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> Co-authored-by: jdamore-linode <[email protected]> Co-authored-by: Hana Xu <[email protected]> * Revert "Merging latest develop changes (#23)" (#24) This reverts commit 2887f18. * Merging latest changes develop (#25) * feat: [UIE-8194] - DBaaS major and minor upgrades - 4 (#11199) * feat: [M3-8831] - New GPUv2 egress transfer display (#11209) * Add new gpuV2 egress transferlogic * light cleanup * adjust e2e s * Added changeset: New GPUv2 egress transfer helpers * feedback @coliu-akamai @hkhalil-akamai * feedback @coliu-akamai @jaalah-akamai * feedback optimization * change: [M3-8806] - Disable unsupported images for distributed regions (#11206) ## Description 📝 In the Linode Create flow, when a distributed region is selected, images & distros that do not support distributed regions should be disabled Note: It looks like the distributions are now sorted alphabetically. I don't see any issues with this but just wanted to point that out in case anyone did ## Changes 🔄 List any change relevant to the reviewer. - Disable unsupported images/distros for distributed regions in Linode Create - Removed the distributed icon & associated icon text - Removed the word `currently` in the Add-Ons warning notice for distributed regions - Added a new generic `ListItemOption` component and refactored `ImageOption`, `PlacementGroupSelectOption`, and `RegionOption` to use new generic component ## Target release date 🗓️ 11/12 ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags ### Verification steps (How to verify changes) - Go to the Linode Create page and verify the following on the `OS` tab and `Images` tab: - Select a core region -> No Images/distributions should be disabled - Select a distributed region -> Images/distributions that do not support distributed regions should be disabled - There should be no regressions in the components that were refactored - Ensure unit tests and e2e tests are passing locally/remotely * fix: [UIE-8246] - DBaaS provisioning 2 node clusters (#11218) * feat : [M3-8528] - Include Object Storage buckets in Support tickets' dropdown (#11178) * feat: [M3-8528] - Include Object Storage in Support Tickets * query change * Added changeset: Include Object Storage buckets in Support tickets dropdown * added link support for object storage * removed redundant query * query updation and restructuring request payload * Added changeset * Initial Changelog * refactor: [M3-8646] – Migrate `Divider` to `ui` package (#11205) * refactor: [M3-8646] – Migrate `Divider` to `ui` package * Added changeset: Migrate Divider to ui package * migrating all imports * removing redundant hook imports * updated the import for omittedProps * UIE-8247: Conditionally give the new docs as the link on database landing page (#11227) * fix: [M3-8764] - Kubernetes UI issues (#11217) * initial clean up * save progress * add changeset * fix type error * feedback @mjac0bs * a few more small fixes * a few more small fixes --------- Co-authored-by: Banks Nussman <[email protected]> * upcoming: [DI-21811] - Post processing of missing timestamp data across dimensions in ACLP charts (#11225) * upcoming: [DI-18419] - chart post processing for missing timestamps * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Code corrections and refactoring * upcoming: [DI-21811] - Added changeset * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - comment updates * upcoming: [DI-21811] - early returns for empty array --------- Co-authored-by: vmangalr <[email protected]> * Update changelog * refactor: [M3-8650] - Migrate Stack to `@linode/ui` package (#11228) * migrate stack, update organization for divider/icon button * Added changeset: `Stack` component to `ui` package * refactor: [M3-8710] - Move `Notice` & `Tooltip` components to UI package and update imports (#11174) * Move Notice to UI package and update imports * Add test imports * Add renderWithTheme and other changes to make tests pass * Fix broken icon imports * Added changeset: Move `Notice` and `Tooltip` components to UI package * Feedback @dwiley-akamai: consolidate imports and rename icon exports * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. (#11172) * change: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object. * Added changeset: change Linode Details Summary VPC IPv4 Text to Copy Object. * Update changeset description Co-authored-by: Purvesh Makode <[email protected]> * remove optional chaining * change Text from "Subnets" to "Subnet" * remove extra borderTop * refactor: [M3-7337] - change Linode Details Summary VPC IPv4 Text to Copy Object * Add descriptive variable name --------- Co-authored-by: Purvesh Makode <[email protected]> * upcoming: [DI-21814] - ACLP UI - DBaaS instances order by label (#11226) * upcoming: [DI-21814] - DBaaS instances order by label * upcoming: [DI-21814] - Added changeset * DI-21814: use map for better readability and optimisations --------- Co-authored-by: vmangalr <[email protected]> * UIE-8254: Add tooltip for ipv6 for new db clusters (#11231) * feat: [UIE-8193] - Usable Storage Tooltip for Create/Resize Database table (#11232) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * feat: [UIE-8193] - Tooltip context for small screens * feat: [UIE-8193] - Tooltip for Create/Resize Database table (#11223) * feat: [UIE-8193] - Tooltip for Create/Resize Database table * Added changeset: Tooltip for 'Usable Storage' in Create/Resize Database Table * feat: [UIE-8193] - Tooltip context for small screens * DBaaS additions * GPU egress transfer copy update (#11235) * default behavior when creating new child clusters should match what existed before we enabled IPACL (in other words: disabled by default) (#11234) Co-authored-by: Talmai Oliveira <[email protected]> * Update PULL_REQUEST_TEMPLATE.md (#11219) * change: [M3-8860] - Update unit testing docs to prefer `userEvent` over `fireEvent` (#11221) * Update 08-testing.md for userEvent * Fix typo * Address feedback; also further clean up linting issues the doc * Fix a bad test that was not following good practices * Added changeset: Update developer docs on unit testing user events * Update changelog * Fix LKE create ACL tests (#11237) * feat: [M3-8665] - add option to copy token in LKE details page. (#11179) * feat: [M3-8665] - add option to copy token in LKE details page. * Added changeset: option to copy token in LKE details page * Change the "Copy Token" button to use asynchronous functionality * remove extra styling * refactor: [M3-8665] - add option to copy token in LKE details page. * Change cypress test for LKE update spec * fix: sx styling for Textfield component (#11246) * spread containerProps sx * spread props.sx as well whoops * fix: [M3-8894] - Linode Create crash when selected a Linode with a `type` that is `null` (#11247) * don't fetch when `type` is an empty string * fix and changelog entry --------- Co-authored-by: Banks Nussman <[email protected]> * change: [M3-8857] - Update PULL_REQUEST_TEMPLATE (Part 2) (#11236) * Make updates discussed to PR template during retro * Add changeset * refactor: [M3-8900] - Move `RadioGroup` to `@linode/ui` package (#11254) * Move RadioGroup to ui package * Added changeset: Move `RadioGroup` from `manager` to `ui` package --------- Co-authored-by: corya-akamai <[email protected]> Co-authored-by: Alban Bailly <[email protected]> Co-authored-by: Hana Xu <[email protected]> Co-authored-by: Harsh Shankar Rao <[email protected]> Co-authored-by: Jaalah Ramos <[email protected]> Co-authored-by: rodonnel-akamai <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: venkatmano-akamai <[email protected]> Co-authored-by: vmangalr <[email protected]> Co-authored-by: Connie Liu <[email protected]> Co-authored-by: Hussain Khalil <[email protected]> Co-authored-by: hasyed-akamai <[email protected]> Co-authored-by: Purvesh Makode <[email protected]> Co-authored-by: ankitaakamai <[email protected]> Co-authored-by: mpolotsk-akamai <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: John Callahan <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> Co-authored-by: jdamore-linode <[email protected]> Co-authored-by: Hana Xu <[email protected]> * upcoming: [DI-21694] - Added changesets * upcoming : [DI-21694] - Addressed the review comments * upcoming: [DI-21694] - Fixed the type safety issue for the AlertSeveritySelect component * upcoming: [DI-21694] - Fixed the dependency if Button component that was failing the test --------- Co-authored-by: corya-akamai <[email protected]> Co-authored-by: Alban Bailly <[email protected]> Co-authored-by: Hana Xu <[email protected]> Co-authored-by: Harsh Shankar Rao <[email protected]> Co-authored-by: Jaalah Ramos <[email protected]> Co-authored-by: rodonnel-akamai <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: venkatmano-akamai <[email protected]> Co-authored-by: vmangalr <[email protected]> Co-authored-by: Connie Liu <[email protected]> Co-authored-by: Hussain Khalil <[email protected]> Co-authored-by: hasyed-akamai <[email protected]> Co-authored-by: Purvesh Makode <[email protected]> Co-authored-by: ankitaakamai <[email protected]> Co-authored-by: mpolotsk-akamai <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: Talmai Oliveira <[email protected]> Co-authored-by: John Callahan <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> Co-authored-by: jdamore-linode <[email protected]> Co-authored-by: Hana Xu <[email protected]>
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
As developers, we want to provide better clarity to our PR template.
Changes 🔄
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply